Skip to content

Explicitly unset PGHOST for temporary server communications #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

Explicitly unset PGHOST for temporary server communications #808

merged 1 commit into from
Jan 21, 2021

Conversation

tianon
Copy link
Member

@tianon tianon commented Jan 18, 2021

Fixes #807

@tianon tianon mentioned this pull request Jan 18, 2021
Closed
@tianon
Copy link
Member Author

tianon commented Jan 21, 2021 •
edited
Loading

@kruftik (author of #807) + @forcedroidbrain @7rulnik @svintenok @avezhlev @anovosyolov @b0rtvader (all folks who gave #807 a 👍), it would be really helpful if one of you could test this and validate whether it fixes your issue 😉

Edit: easiest way to test is via something like docker build 'https://github.com/docker-library/postgres.git#refs/pull/808/merge:NNN' --pull --tag postgres:NNN (where NNN is the major version/directory you want to test, like "12" or "13")

@kruftik
Copy link

kruftik commented Jan 21, 2021

many thanks for extremely fast fix and sorry for no reaction :( i've just checked the DB init and it seems to be working fine.
I tried with almost all the set of possible PG vars:

PGPORT=6543
PGDATABASE=qwe
PGPASSWORD=qwe
PGHOST=127.0.0.1
PGUSER=qwe

@tianon
Copy link
Member Author

tianon commented Jan 21, 2021

Excellent, thanks! 👍

@tianon tianon merged commit e8cb2ac into docker-library:master Jan 21, 2021
@tianon tianon deleted the PGHOST branch January 21, 2021 16:49
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jan 21, 2021
@docker-library-bot
Update postgres
71cb018 
Changes:

- docker-library/postgres@e8cb2ac: Merge pull request docker-library/postgres#808 from infosiftr/PGHOST
- docker-library/postgres@a6b4262: Merge pull request docker-library/postgres#811 from infosiftr/alpine3.13
- docker-library/postgres@188bf13: Update to Alpine 3.13
- docker-library/postgres@ba30220: Explicitly unset PGHOST for temporary server communications
@tianon tianon mentioned this pull request Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR #801 to postgres image breaks docker-entrypoint initialization logic in CI environments in k8s
2 participants
@tianon @kruftik