Apply thread-related crypt patches in 3.x versions #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
force-pushed
the
thread-patch
branch
2 times, most recently
from
171dd25 to
55176cd
Compare
yosifkit
reviewed
Feb 18, 2021
| @@ -82,6 +83,17 @@ RUN set -eux; \ | |||
| find /opt/pypy/lib-python -depth -type d -a \( -name test -o -name tests \) -exec rm -rf '{}' +; \ | |||
| rm pypy.tar.bz2; \ | |||
| \ | |||
| {{ if is_3 then ( -}} | |||
There was a problem hiding this comment.
Do you think we should also gate on 7.3.3 so that it auto goes away for the next release or would you rather have a failing update.sh job?
There was a problem hiding this comment.
I'd prefer a failing update.sh job so we have a clear reminder/forcing function to actually come and remove it instead of carrying the cruft. 😅
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Feb 18, 2021
Changes: - docker-library/pypy@d660df9: Merge pull request docker-library/pypy#55 from infosiftr/thread-patch - docker-library/pypy@42286a6: Apply thread-related crypt patches in 3.x versions - docker-library/pypy@8b9d85c: Merge pull request docker-library/pypy#53 from infosiftr/jq-template - docker-library/pypy@76a4649: Add initial jq-based templating engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #53
Fixes #49