Skip to content

Remove redundant --with-system-ffi configure option #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Apr 9, 2022

Since as of Python 3.7+ using system ffi is now mandatory (and so the default) on Linux:
https://bugs.python.org/issue27979
python/cpython@f40d4dd

Removing the option resolves this configure warning:

checking for --with-system-ffi... yes
configure: WARNING: --with(out)-system-ffi is ignored on this platform

Closes #715.

Since as of Python 3.7+ using system `ffi` is now mandatory (and so the default)
on Linux:
https://bugs.python.org/issue27979
python/cpython@f40d4dd

Removing the option resolves this configure warning:

```
checking for --with-system-ffi... yes
configure: WARNING: --with(out)-system-ffi is ignored on this platform
```

Closes docker-library#715.
@yosifkit
Copy link
Member

Thanks!

@yosifkit yosifkit merged commit d298086 into docker-library:master Apr 11, 2022
@edmorley edmorley deleted the remove-with-system-ffi branch April 11, 2022 17:06
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Apr 11, 2022
Changes:

- docker-library/python@d298086: Merge pull request docker-library/python#716 from edmorley/remove-with-system-ffi
- docker-library/python@028012a: Remove redundant `--with-system-ffi` configure option
- docker-library/python@1999778: Restore /usr/local/bin/python as a relative symlink to /usr/local/bin/python3, rather than an absolute one (docker-library/python#714)
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Apr 13, 2022
Changes:

- docker-library/python@0b9aee9: Removing LANG env var (docker-library/python#570)
- docker-library/python@d298086: Merge pull request docker-library/python#716 from edmorley/remove-with-system-ffi
- docker-library/python@028012a: Remove redundant `--with-system-ffi` configure option
- docker-library/python@1999778: Restore /usr/local/bin/python as a relative symlink to /usr/local/bin/python3, rather than an absolute one (docker-library/python#714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --with-system-ffi configure option is redundant on Linux for Python 3.7+
2 participants