Skip to content

Please mention RABBITMQ_DEFAULT_USER / RABBITMQ_DEFAULT_PASS in the Readme #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
klamann opened this issue Oct 18, 2021 · 4 comments · Fixed by docker-library/docs#2069
Closed

Please mention RABBITMQ_DEFAULT_USER / RABBITMQ_DEFAULT_PASS in the Readme #526

klamann opened this issue Oct 18, 2021 · 4 comments · Fixed by docker-library/docs#2069
Labels
Request Request for image modification or feature

Comments

@klamann
Copy link

klamann commented Oct 18, 2021

I just stumbled upon #508 after I tried to figure out how I can provide a username and password to RabbitMQ 3.9 in a GitLab CI pipeline.

So the Readme says that the use of environment variables to configure RabbitMQ is not possible anymore, but then in rabbitmq-server#3299, support for the variables RABBITMQ_DEFAULT_VHOST, RABBITMQ_DEFAULT_USER and RABBITMQ_DEFAULT_PASS was added.

Can you mention this in the Readme on Dockerhub? There are quite a few situations (like GitHub Actions or GitLab CI) where mounting config files is not an option and it would be nice if the Readme helped with that.
@wglambert wglambert added the Request Request for image modification or feature label Oct 18, 2021
@wglambert
Copy link

This PR docker-library/docs#2012 removed the newly supported variables from the disallowed list. So users would be able to see the complete list of supported variables at https://www.rabbitmq.com/configure.html#supported-environment-variables

Seems like their docs weren't updated yet with the new supported variables

@klamann
Copy link
Author

klamann commented Oct 18, 2021

yeah, it's not in the offcial documentation, would be nice if it was updated.
But there's basically two pieces of information I'm looking for in the Readme of any docker image:

  • which tag should I use?
  • how can I specify credentials?

The current Readme does a really good job with the tags, but there is no information to be found regarding credentials, other than a link to a convoluted page which tells you (incorrectly) that the only way to change the password is to mount a config file.

I think it would be very helpful to mention these 3 variables in the Readme.

@wglambert wglambert mentioned this issue Oct 30, 2021
Merged
michaelklishin added a commit to rabbitmq/rabbitmq-website that referenced this issue Nov 17, 2021
@michaelklishin
Document RABBiTMQ_DEFAULT_USER and friends
ec238a2 
Available in recent 3.9 and 3.8 patch releases.

References docker-library/rabbitmq#508,
docker-library/rabbitmq#526, docker-library/docs#2069
@michaelklishin
Copy link
Collaborator

michaelklishin commented Nov 17, 2021 •
edited
Loading

FYI: rabbitmq/rabbitmq-website@ec238a2. RabbitMQ docs are open source, so changes similar to the above one can be contributed by anyone ;)

@vgoklani
Copy link

Why were the environment variables removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Request Request for image modification or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-add rabbitmq docs section for auth env vars
4 participants
@michaelklishin @vgoklani @klamann @wglambert