Enable JIT, install g++ #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erlang 24 provide JIT support that requires c++17-compatible compiler. Without the g++ package, `autoconf` considers this support missing and therefore silently disables JIT. This commits makes sure that: 1. g++ is installed (this makes `autoconf` detect it correctly as c++17-compatible) 2. Explicitly enables JIT so that it fails in case something changes in the future. JIT is a great feature so we don't want it being silently turned off for any reason. Co-authored-by: Michal Kuratczyk <mkuratczyk@vmware.com>
ansd
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jun 21, 2021
See docker-library/rabbitmq#492 Co-authored-by: Michal Kuratczyk <mkuratczyk@vmware.com>
ansd
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jun 21, 2021
See docker-library/rabbitmq#492 Co-authored-by: Michal Kuratczyk <mkuratczyk@vmware.com> Ensure compilation and runtime Erlang are in sync Bump to Ubuntu 20.04 docker-library/rabbitmq also uses Ubuntu 20.04
|
I forgot to mention how to test this change - the first line of |
|
Change seems fine to me. @michaelklishin or @gerhard, any reason this shouldn't be enabled? |
|
Let's merge this 👍 |
michaelklishin
approved these changes
Jun 23, 2021
Merged
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 23, 2021
Changes: - docker-library/rabbitmq@59d7871: Merge pull request docker-library/rabbitmq#424 from infosiftr/entrypoint-deprecation - docker-library/rabbitmq@bc88db1: Merge pull request docker-library/rabbitmq#492 from mkuratczyk/master - docker-library/rabbitmq@051164d: Switch from SKS to Ubuntu keyserver - docker-library/rabbitmq@973c614: Add missing `\` - docker-library/rabbitmq@38ead37: Enable JIT, install g++ - docker-library/rabbitmq@8942a4b: Merge pull request docker-library/rabbitmq#490 from J0WI/alpine-3.14 - docker-library/rabbitmq@59c5913: Alpine 3.14 - docker-library/rabbitmq@2fab209: Add deprecation warnings to "docker-entrypoint.sh"
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 26, 2021
Changes: - docker-library/rabbitmq@226c6de: Update 3.8-rc to 3.8.18-rc.1 - docker-library/rabbitmq@4792573: Update 3.8 to 3.8.18 - docker-library/rabbitmq@59d7871: Merge pull request docker-library/rabbitmq#424 from infosiftr/entrypoint-deprecation - docker-library/rabbitmq@bc88db1: Merge pull request docker-library/rabbitmq#492 from mkuratczyk/master - docker-library/rabbitmq@051164d: Switch from SKS to Ubuntu keyserver - docker-library/rabbitmq@973c614: Add missing `\` - docker-library/rabbitmq@38ead37: Enable JIT, install g++ - docker-library/rabbitmq@8942a4b: Merge pull request docker-library/rabbitmq#490 from J0WI/alpine-3.14 - docker-library/rabbitmq@59c5913: Alpine 3.14 - docker-library/rabbitmq@2fab209: Add deprecation warnings to "docker-entrypoint.sh"
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 28, 2021
Changes: - docker-library/rabbitmq@ad1824a: Update 3.8-rc to otp 24.0.3 - docker-library/rabbitmq@5414666: Update 3.8 to otp 24.0.3 - docker-library/rabbitmq@226c6de: Update 3.8-rc to 3.8.18-rc.1 - docker-library/rabbitmq@4792573: Update 3.8 to 3.8.18 - docker-library/rabbitmq@59d7871: Merge pull request docker-library/rabbitmq#424 from infosiftr/entrypoint-deprecation - docker-library/rabbitmq@bc88db1: Merge pull request docker-library/rabbitmq#492 from mkuratczyk/master - docker-library/rabbitmq@051164d: Switch from SKS to Ubuntu keyserver - docker-library/rabbitmq@973c614: Add missing `\` - docker-library/rabbitmq@38ead37: Enable JIT, install g++ - docker-library/rabbitmq@8942a4b: Merge pull request docker-library/rabbitmq#490 from J0WI/alpine-3.14 - docker-library/rabbitmq@59c5913: Alpine 3.14 - docker-library/rabbitmq@2fab209: Add deprecation warnings to "docker-entrypoint.sh"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erlang 24 provides JIT support that requires c++17-compatible compiler.
Without the
g++package,autoconfconsiders this support missing andtherefore silently disables JIT. This commit makes sure that:
autoconfdetect it correctly asc++17-compatible)
the future. JIT is a great feature so we don't want it being silently
turned off for any reason.