Skip to content

Use conf.d to enable console logging in RMQ 3.9+ #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Use conf.d to enable console logging in RMQ 3.9+ #555

merged 1 commit into from
Mar 22, 2022

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Mar 18, 2022

This replaces the RABBITMQ_LOGS=- env variable.

Fixes #554

Test procedure is documented here:

https://github.com/lukebakken/test-docker-library-rabbitmq-gh-554

@michaelklishin
Copy link
Collaborator

I tested an image built from this branch and logging works as expected,

@michaelklishin
Copy link
Collaborator

@lukebakken has an example repo with some instructions: https://github.com/lukebakken/test-docker-library-rabbitmq-gh-554

@tianon
Copy link
Member

tianon commented Mar 18, 2022

Do you think it'd be reasonable for us to combine these two config files into a 00-docker-defaults.conf or even 10-docker-defaults.conf (so users can inject either before or after without too much hassle), or do you think having these separate like this is better?

@lukebakken
Copy link
Collaborator Author

@tianon great question. I only added a new file because of the comment in the existing one:

https://github.com/docker-library/rabbitmq/blob/master/10-default-guest-user.conf#L1-L3

I'll modify the PR to combine the files into 10-defaults.conf. I will add a note about log.console being necessary if you want to see logs the "usual" way in a container.

This replaces the `RABBITMQ_LOGS=-` env variable.

Fixes #554
@michaelklishin
Copy link
Collaborator

I like the idea of combining them. Why would anyone add a file before these defaults, though? Aren't defaults meant to be overridden? ;) anyhow, 10-defaults.conf SGTM.

@lukebakken
Copy link
Collaborator Author

@tianon thanks for your quick reviews.

@lukebakken
Copy link
Collaborator Author

I just read through #506 and this PR does not seem to introduce a situation like the one described there, thankfully.

@michaelklishin
Copy link
Collaborator

@tianon is there anything else we should do to get this in? :)

@tianon
Copy link
Member

tianon commented Mar 22, 2022

Sorry, just patience 🙈

Thanks! ❤️

@tianon tianon merged commit baaf5d0 into docker-library:master Mar 22, 2022
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 22, 2022
Changes:

- docker-library/rabbitmq@baaf5d0: Merge pull request docker-library/rabbitmq#555 from lukebakken/lukebakken/docker-librarygh-554
- docker-library/rabbitmq@04b8a1b: Update 3.10-rc to 3.10.0-beta.5
- docker-library/rabbitmq@ea3e24a: Update 3.9 to 3.9.14
- docker-library/rabbitmq@340a388: Update 3.8 to 3.8.28
- docker-library/rabbitmq@3e8f0f1: Use conf.d to enable console logging in RMQ 3.9+
@lukebakken lukebakken deleted the lukebakken/gh-554 branch October 28, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use RABBITMQ_LOGS to configure logging
4 participants