-
Notifications
You must be signed in to change notification settings - Fork 430
Use conf.d to enable console logging in RMQ 3.9+ #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tested an image built from this branch and logging works as expected, |
@lukebakken has an example repo with some instructions: https://github.com/lukebakken/test-docker-library-rabbitmq-gh-554 |
Do you think it'd be reasonable for us to combine these two config files into a |
@tianon great question. I only added a new file because of the comment in the existing one: https://github.com/docker-library/rabbitmq/blob/master/10-default-guest-user.conf#L1-L3 I'll modify the PR to combine the files into |
This replaces the `RABBITMQ_LOGS=-` env variable. Fixes #554
I like the idea of combining them. Why would anyone add a file before these defaults, though? Aren't defaults meant to be overridden? ;) anyhow, |
@tianon thanks for your quick reviews. |
I just read through #506 and this PR does not seem to introduce a situation like the one described there, thankfully. |
@tianon is there anything else we should do to get this in? :) |
Sorry, just patience 🙈 Thanks! ❤️ |
Changes: - docker-library/rabbitmq@baaf5d0: Merge pull request docker-library/rabbitmq#555 from lukebakken/lukebakken/docker-librarygh-554 - docker-library/rabbitmq@04b8a1b: Update 3.10-rc to 3.10.0-beta.5 - docker-library/rabbitmq@ea3e24a: Update 3.9 to 3.9.14 - docker-library/rabbitmq@340a388: Update 3.8 to 3.8.28 - docker-library/rabbitmq@3e8f0f1: Use conf.d to enable console logging in RMQ 3.9+
This replaces the
RABBITMQ_LOGS=-
env variable.Fixes #554
Test procedure is documented here:
https://github.com/lukebakken/test-docker-library-rabbitmq-gh-554