Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3.13.0-beta.2 #652

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add 3.13.0-beta.2 #652

merged 1 commit into from
Jul 19, 2023

Conversation

tianon
Copy link
Member

@tianon tianon commented Jun 27, 2023 •
edited
Loading

@tianon
Copy link
Member Author

tianon commented Jun 27, 2023 •
edited
Loading

Oh hmm, those notes say "This release requires Erlang 25.0 or later." near the top, but then later "Starting with this release, RabbitMQ requires Erlang 26.0 or later versions."

I guess we should update to 26 here (and those notes probably should be updated). 😅

(Relevant: #636)

@michaelklishin
Copy link
Collaborator

Thank you! I was about to open an issue requesting a 3.13 preview :)

Yes, 3.13 will require 26 even though it does not right now. Let's move to Erlang 26 for 3.13.

@tianon
Copy link
Member Author

tianon commented Jun 27, 2023

Hmm, the build looks good, but our rabbitmq-tls test is failing (https://github.com/docker-library/official-images/tree/master/test/tests/rabbitmq-tls); not sure exactly why yet. 😭

(it looks like it's never getting past rabbitmq-diagnostics check_port_connectivity 😞)

@michaelklishin
Copy link
Collaborator

@tianon Erlang 26 breaks TLS by changing some defaults. Namely, peer verification is now on by default. We disabled it by default in RabbitMQ's own test suites.

lukebakken added a commit to lukebakken/docker-library_official-images that referenced this pull request Jun 28, 2023
@lukebakken
Set CN to container DNS name
c0183c8 
Related to docker-library/rabbitmq#652

cc @tianon
@lukebakken lukebakken mentioned this pull request Jun 28, 2023
Merged
@lukebakken
Copy link
Collaborator

@tianon this PR might address the issue, but I have no idea the best way to test it -

docker-library/official-images#14951

lukebakken added a commit to lukebakken/docker-library_official-images that referenced this pull request Jun 29, 2023
@lukebakken
Set CN to container DNS name
d1c2575 
Related to docker-library/rabbitmq#652
lukebakken added a commit to lukebakken/docker-library_official-images that referenced this pull request Jul 12, 2023
@lukebakken
Set CN to container DNS name
b706d45 
Related to docker-library/rabbitmq#652
@lukebakken
Copy link
Collaborator

Related issue - erlang/otp#7497

@yosifkit
Copy link
Member

That is amazing. 🎉 Thanks so much @lukebakken for digging into the failure and finding where the bug is! ❤️❤️❤️

@lukebakken lukebakken mentioned this pull request Jul 14, 2023
Closed
lukebakken added a commit to lukebakken/docker-library_official-images that referenced this pull request Jul 14, 2023
@lukebakken
Set CN to container DNS name
dee1b88 
Related to docker-library/rabbitmq#652

Give a TLS dist optfile a try

Remove `fail_if_no_peer_cert` option for client. It does not seem to be supported by OTP 26 🤔
@lukebakken
Copy link
Collaborator

docker-library/official-images#14951 should fix the check_port_connectivity issue, and then this PR should be good-to-go.

tianon pushed a commit to lukebakken/docker-library_official-images that referenced this pull request Jul 19, 2023
@lukebakken @tianon
Set CN to container DNS name
e3a1857 
Related to docker-library/rabbitmq#652

Give a TLS dist optfile a try

Remove `fail_if_no_peer_cert` option for client. It does not seem to be supported by OTP 26 🤔
@tianon tianon changed the title Add 3.13.0-beta.1 Add 3.13.0-beta.2 Jul 19, 2023
@tianon
Copy link
Member Author

tianon commented Jul 19, 2023

Updated to 3.13.0-beta.2, docker-library/official-images#14951 is in, hopefully this should be good to go now! 🤞

@yosifkit yosifkit merged commit e593e23 into docker-library:master Jul 19, 2023
17 checks passed
@yosifkit yosifkit deleted the 3.13-beta branch July 19, 2023 20:00
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jul 19, 2023
@docker-library-bot
Update rabbitmq
3953094 
Changes:

- docker-library/rabbitmq@e593e23: Merge pull request docker-library/rabbitmq#652 from infosiftr/3.13-beta
- docker-library/rabbitmq@80011d7: Add 3.13.0-beta.2
- docker-library/rabbitmq@055e60f: Update 3.10 to otp 25.3.2.4
- docker-library/rabbitmq@5541d12: Update 3.10 to otp 25.3.2.3
- docker-library/rabbitmq@e8e80fc: Add minor GHA improvements
@yosifkit yosifkit mentioned this pull request Jul 19, 2023
Merged
@lukebakken lukebakken mentioned this pull request Jul 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tianon @michaelklishin @lukebakken @yosifkit