chown of the www root folder. #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the interest of not breaking people, only chown the root directory when we've determined WordPress is not installed, the permissions on the directory are root:root/0:0 (and it is thus likely the directory was "helpfully" auto-created by Docker), and we are running as root (and thus able to chown).
|
I've pushed a minor adjustment to both add this to the
LGTM cc @yosifkit |
|
(current Travis failures are due to #372) |
yosifkit
approved these changes
Feb 1, 2019
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Feb 1, 2019
- `golang`: Alpine 3.9 (docker-library/golang#262) - `haproxy`: Alpine 3.9 (docker-library/haproxy#82) - `httpd`: Alpine 3.9 (docker-library/httpd#124) - `mariadb`: 10.0.38, 5.5.63 - `memcached`: Alpine 3.9 (docker-library/memcached#45) - `mysql`: 8.0.15 - `openjdk`: 13-ea+6, 12-ea+30, Alpine 3.9 (docker-library/openjdk#276) - `php`: axe 5.6 (EOL), consistent `/var/www/html` permissions (docker-library/php#787) - `postgres`: Alpine 3.9 (docker-library/postgres#550) - `rabbitmq`: 3.7.11, 3.8.0-beta.2 - `redis`: Alpine 3.9 (redis/docker-library-redis#183) - `ruby`: Alpine 3.9 (docker-library/ruby#262) - `wordpress`: `chown` of `.` in very certain narrow cases (docker-library/wordpress#371)
Firefishy
pushed a commit
to Firefishy/official-images
that referenced
this pull request
Feb 18, 2019
- `golang`: Alpine 3.9 (docker-library/golang#262) - `haproxy`: Alpine 3.9 (docker-library/haproxy#82) - `httpd`: Alpine 3.9 (docker-library/httpd#124) - `mariadb`: 10.0.38, 5.5.63 - `memcached`: Alpine 3.9 (docker-library/memcached#45) - `mysql`: 8.0.15 - `openjdk`: 13-ea+6, 12-ea+30, Alpine 3.9 (docker-library/openjdk#276) - `php`: axe 5.6 (EOL), consistent `/var/www/html` permissions (docker-library/php#787) - `postgres`: Alpine 3.9 (docker-library/postgres#550) - `rabbitmq`: 3.7.11, 3.8.0-beta.2 - `redis`: Alpine 3.9 (redis/docker-library-redis#183) - `ruby`: Alpine 3.9 (docker-library/ruby#262) - `wordpress`: `chown` of `.` in very certain narrow cases (docker-library/wordpress#371)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #369
change the owner of the web root folder, so that wordpress can upgrade.