Skip to content
This repository was archived by the owner on Oct 26, 2019. It is now read-only.

Fix ExecIds type in container inspect in swagger file #1

Closed
wants to merge 1 commit into from
Closed

Fix ExecIds type in container inspect in swagger file #1

wants to merge 1 commit into from

Conversation

Rid
Copy link

@Rid Rid commented Apr 24, 2018

Fixes docker-php/docker-php#304 where ExecIds expects a string but gets an array

Fixes docker-php/docker-php#304 where ExecIds expects a string but gets an array
@jcrombez
Copy link

Anyone can merge this ?

@Rid
Copy link
Author

Rid commented Sep 15, 2018

I had this merged upstream moby/moby#36962 and made a fork using 1.37, you're welcome to use it until this is updated, just put this in your composer.json:

...
    "repositories": [
      {
        "type": "package",
        "package": {
          "name": "docker-php/docker-php-api",
          "version": "4.1.37",
          "source": {
            "url": "https://github.com/Rid/docker-php-api.git",
            "type": "git",
            "reference": "4.1.37"
          },
          "autoload": {
            "classmap": [""]
          }
        }
      },
    ],
...
    "require": {
        ...
        "docker-php/docker-php-api": "4.1.37",
    },

@jcrombez
Copy link

Thank you ! @Rid

@jcrombez
Copy link

jcrombez commented Sep 18, 2018

I tried using your fork but i get this error :

PHP Fatal error:  Class 'Jane\OpenApiRuntime\Client\Psr7HttplugClient' not found in /app/vendor/docker-php/docker-php-api/src/Client.php on line 13

So i added the deps manually, but then i get the invalid supplied for foreach warning i had initially so i guess my issue isn't exactly the same as this PR aim to fix.

PHP Warning:  Invalid argument supplied for foreach() in /app/vendor/docker-php/docker-php-api/src/Normalizer/NetworkSettingsNormalizer.php on line 60

@jcrombez
Copy link

my bad it was the other PR :$

@rodrigoaguilera
Copy link

Can we have this simple change merged?

@Chakratos
Copy link

please merge this, a big project of mine is depending on this merge.

@Rid
Copy link
Author

Rid commented Aug 21, 2019

I've updated my fork to docker api 1.41, you can use it by adding the following to your composer.json:

...
    "repositories": [
      {
        "type": "package",
        "package": {
          "name": "docker-php/docker-php-api",
          "version": "4.1.41",
          "source": {
            "url": "https://github.com/Rid/docker-php-api.git",
            "type": "git",
            "reference": "4.1.41"
          },
          "autoload": {
            "classmap": [""]
          }
        }
      },
    ],
...
    "require": {
        ...
        "docker-php/docker-php-api": "4.1.41",
    },

@rodrigoaguilera
Copy link

Have you proposed this changes upstream?

This project seems pretty abandoned so maybe it needs anew maintainer

@Rid
Copy link
Author

Rid commented Aug 21, 2019

@rodrigoaguilera this is the upstream repo, it generates the php methods and classes for https://github.com/docker-php/docker-php

I would be happy to maintain this repo if @joelwurtz gives me the required permissions.

@Rid Rid closed this by deleting the head repository Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP Fatal error when inspecting a container and "ExecIDs" is an array.
4 participants