Removes explicit dependency on Rack #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of rack requires Ruby >= 2.2.2, so the build fails.
```
Step 4 : RUN gem install --no-ri --no-rdoc bundler sinatra faker i18n tilt rack rack-protection sinatra-reloader
---> Running in 5ed9d4b68edb
ERROR: Error installing rack:
rack requires Ruby version >= 2.2.2.
Successfully installed bundler-1.12.5
Successfully installed rack-1.6.4
Successfully installed tilt-2.0.5
Successfully installed rack-protection-1.5.3
Successfully installed sinatra-1.4.7
Successfully installed i18n-0.7.0
Successfully installed faker-1.6.5
Successfully installed i18n-0.7.0
Successfully installed tilt-2.0.5
Successfully installed rack-protection-1.5.3
Successfully installed backports-3.6.8
Successfully installed rack-test-0.6.3
Successfully installed multi_json-1.12.1
Successfully installed sinatra-contrib-1.4.7
Successfully installed sinatra-reloader-1.0
15 gems installed
The command '/bin/sh -c gem install --no-ri --no-rdoc bundler sinatra faker i18n tilt rack rack-protection sinatra-reloader' returned a non-zero code: 1
```
This commit removes the explicit dependency and let the rack-protection provide rack as a transitive dependency, which will not fail the build as it will pick a compatible version.
```
Step 4 : RUN gem install --no-ri --no-rdoc bundler sinatra faker i18n tilt rack-protection sinatra-reloader
---> Running in fa72ebcff776
Successfully installed bundler-1.12.5
Successfully installed rack-1.6.4
Successfully installed tilt-2.0.5
Successfully installed rack-protection-1.5.3
Successfully installed sinatra-1.4.7
Successfully installed i18n-0.7.0
Successfully installed faker-1.6.5
Successfully installed i18n-0.7.0
Successfully installed tilt-2.0.5
Successfully installed rack-protection-1.5.3
Successfully installed backports-3.6.8
Successfully installed rack-test-0.6.3
Successfully installed multi_json-1.12.1
Successfully installed sinatra-contrib-1.4.7
Successfully installed sinatra-reloader-1.0
15 gems installed
---> 85b56e326c59
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of rack requires Ruby >= 2.2.2, so the build fails.
This commit removes the explicit dependency and let the rack-protection provide rack as a transitive dependency, which will not fail the build as it will pick a compatible version.