Skip to content

Commit

Permalink
Merge pull request #488 from crazy-max/test-node-multi
Browse files Browse the repository at this point in the history
ci: test supported node versions
  • Loading branch information
crazy-max authored Nov 22, 2024
2 parents 24f1be5 + e2dbc98 commit d99f9fd
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 1 deletion.
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ on:
jobs:
build:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node_version:
- 20
- 18
steps:
-
name: Checkout
Expand All @@ -24,3 +30,5 @@ jobs:
uses: docker/bake-action@v5
with:
targets: build
env:
NODE_VERSION: ${{ matrix.node_version }}
9 changes: 8 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ env:
jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node_version:
- 20
- 18
steps:
-
name: Checkout
Expand All @@ -32,6 +38,7 @@ jobs:
targets: test-coverage
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NODE_VERSION: ${{ matrix.node_version }}
-
name: Check coverage
run: |
Expand All @@ -44,7 +51,7 @@ jobs:
-
name: Upload coverage
uses: codecov/codecov-action@v5
if: env.RUN_CODECOV == 'true'
if: env.RUN_CODECOV == 'true' && matrix.node_version == env.NODE_VERSION
with:
files: ./coverage/clover.xml
flags: unit
Expand Down
18 changes: 18 additions & 0 deletions docker-bake.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
// See the License for the specific language governing permissions and
// limitations under the License.

variable "NODE_VERSION" {
default = null
}

group "default" {
targets = ["build"]
}
Expand All @@ -24,31 +28,42 @@ group "validate" {
targets = ["lint", "vendor-validate", "dockerfile-validate", "license-validate"]
}

target "_common" {
args = {
NODE_VERSION = NODE_VERSION
}
}

target "build" {
inherits = ["_common"]
dockerfile = "dev.Dockerfile"
target = "build-update"
output = ["."]
}

target "format" {
inherits = ["_common"]
dockerfile = "dev.Dockerfile"
target = "format-update"
output = ["."]
}

target "lint" {
inherits = ["_common"]
dockerfile = "dev.Dockerfile"
target = "lint"
output = ["type=cacheonly"]
}

target "vendor" {
inherits = ["_common"]
dockerfile = "dev.Dockerfile"
target = "vendor-update"
output = ["."]
}

target "vendor-validate" {
inherits = ["_common"]
dockerfile = "dev.Dockerfile"
target = "vendor-validate"
output = ["type=cacheonly"]
Expand All @@ -67,13 +82,15 @@ target "dockerfile-validate" {
}

target "test" {
inherits = ["_common"]
dockerfile = "dev.Dockerfile"
target = "test"
output = ["type=cacheonly"]
secret = ["id=GITHUB_TOKEN,env=GITHUB_TOKEN"]
}

target "test-coverage" {
inherits = ["_common"]
dockerfile = "dev.Dockerfile"
target = "test-coverage"
output = ["./coverage"]
Expand All @@ -87,6 +104,7 @@ variable "GITHUB_REF" {
}

target "publish" {
inherits = ["_common"]
dockerfile = "dev.Dockerfile"
args = {
GITHUB_REF = GITHUB_REF
Expand Down

0 comments on commit d99f9fd

Please sign in to comment.