Skip to content

Commit

Permalink
docker/install: Fix lima failing to download latest Docker archive
Browse files Browse the repository at this point in the history
Use the actual version number resolved from the Github releases instead
of the `latest` string.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
  • Loading branch information
vvoland committed Oct 29, 2024
1 parent 5abb5fc commit e2acba1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions __tests__/docker/install.test.itg.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ aarch64:https://cloud.debian.org/images/cloud/bookworm/20231013-1532/debian-12-g
{type: 'image', tag: '27.3.1'} as InstallSourceImage,
{type: 'image', tag: 'master'} as InstallSourceImage,
{type: 'archive', version: 'v26.1.4', channel: 'stable'} as InstallSourceArchive,
{type: 'archive', version: 'latest', channel: 'stable'} as InstallSourceArchive,
])(
'install docker %s', async (source) => {
if (process.env.ImageOS && process.env.ImageOS.startsWith('ubuntu')) {
Expand Down
2 changes: 1 addition & 1 deletion src/docker/install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export class Install {
daemonConfig: limaDaemonConfig,
dockerSock: `${limaDir}/docker.sock`,
srcType: src.type,
srcArchiveVersion: srcArchive.version?.replace(/^v/, ''),
srcArchiveVersion: this._version, // Use the resolved version (e.g. latest -> 27.4.0)
srcArchiveChannel: srcArchive.channel,
srcImageTag: (src as InstallSourceImage).tag
});
Expand Down

0 comments on commit e2acba1

Please sign in to comment.