Remove quotes around env variable name in resolveBuildSecretEnv #176
Conversation
|
@crazy-max sorry for the ping, I hope this can get merged as it is a quite blocking issue for reading env variables to secrets. After this I will create a pull request in the action to make use of this change. |
There was a problem hiding this comment.
LGTM thanks! And sorry for the delay!
About the implementation on build push action, see my comment #110 (comment)
No worries! Just like he said i do not have access to providing inputs directly to the action. In my case it lives in a reusable workflow which can define environment variables but not like that directly. In our case environment variables can be defined dynamically when running the workflow including env vars that contain secrets. There is also another input to this workflow that says what secrets should point to what environment variables. |
|
@crazy-max just a few more questions: When will a new npm package version of this be released? In the pull request to the GitHub action should i bump the package version with it? ❤️ |
|
Released https://github.com/docker/actions-toolkit/releases/tag/v0.13.0-rc.1 if you want to bump |
When trying to implement an input for secrets defined by environment variables to the build-push-action I made use of the new
resolveBuildSecretEnvimplemented in: a1ffbe9.I implemented a test for the new input and it didn't work due to csv parsing breaking because of the quotes around the env variable name as can be seen here. After monkeypatching this function (removing the
"around the env variable name) and building again it works correctly as can be seen here.Pasting images since action runs disappear after a while:
