bake: handle build checks from metadata #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
bake-warnings
branch
4 times, most recently
from
b76f020
to
222b4ef
Compare
crazy-max
changed the title
crazy-max
commented
Jul 30, 2024
Comment on lines
+15
to
+26
| group "default" { | ||
| targets = ["lint", "lint-other", "lint-inline"] | ||
| } | ||
| target "lint" { | ||
| dockerfile = "lint.Dockerfile" | ||
| } | ||
| target "lint-other" { | ||
| dockerfile = "lint-other.Dockerfile" | ||
| } | ||
| target "lint-inline" { | ||
| dockerfile-inline = "FRoM alpine\nENTRYPOINT [\"echo\", \"hello\"]" | ||
| } |
There was a problem hiding this comment.
based on this hcl definition, we can see no annotation are generated for lint-inline target as the dockerfile is inline: https://github.com/docker/actions-toolkit/actions/runs/10166368516/job/28116386475?pr=389#step:10:201
crazy-max
force-pushed
the
bake-warnings
branch
3 times, most recently
from
ccc68a5
to
47f1b48
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up