This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Mark docker app plugin as experimental #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvin-lubecki
changed the title
|
@simonferquel can you review the |
ijc
approved these changes
May 22, 2019
There was a problem hiding this comment.
LGTM. You edits to the context stuff appear to be consistent with docker/cli@a3efd5d
silvin-lubecki
force-pushed
the
experimental-plugin
branch
2 times, most recently
from
869f73f to
fefc7ae
Compare
silvin-lubecki
changed the title
silvin-lubecki
force-pushed
the
experimental-plugin
branch
from
fefc7ae to
fffb715
Compare
…mental flag enabled will list docker app as a plugin. Bump docker/cli to the last 19.03 Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
silvin-lubecki
force-pushed
the
experimental-plugin
branch
from
fffb715 to
cbdc839
Compare
chris-crone
approved these changes
May 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 69.94% 69.94%
=======================================
Files 55 55
Lines 3101 3101
=======================================
Hits 2169 2169
Misses 639 639
Partials 293 293
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How to verify it
~/.docker/cli-pluginsdirectoryappdoes not appear in the manage commandsappappears in the manage commands- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)