This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 176
Add inspect command to display info of running application only #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
changed the title
WIP Add inspect command to display info of running application only
[WIP] Add inspect command to display info of running application only
Oct 29, 2019
glours
force-pushed
the
inspect_info_running_app_only
branch
7 times, most recently
from
November 4, 2019 16:53
269b4f0
to
3859f01
Compare
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
=========================================
- Coverage 70.48% 69.6% -0.88%
=========================================
Files 62 63 +1
Lines 3208 3349 +141
=========================================
+ Hits 2261 2331 +70
- Misses 641 710 +69
- Partials 306 308 +2
Continue to review full report at Codecov.
|
jcsirot
force-pushed
the
inspect_info_running_app_only
branch
from
November 7, 2019 13:28
f230365
to
02a1d4e
Compare
rumpl
reviewed
Nov 7, 2019
eunomie
reviewed
Nov 7, 2019
jcsirot
force-pushed
the
inspect_info_running_app_only
branch
5 times, most recently
from
November 8, 2019 12:09
25400b6
to
e6522c7
Compare
…nschema to v1.2.0 Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
jcsirot
force-pushed
the
inspect_info_running_app_only
branch
from
November 8, 2019 12:31
e6522c7
to
5c6c2d2
Compare
glours
changed the title
[WIP] Add inspect command to display info of running application only
Add inspect command to display info of running application only
Nov 8, 2019
rumpl
reviewed
Nov 8, 2019
rumpl
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of Qs but LGTM after they are treated
Is the coverage completely wrong or does this PR really reduces the coverage? |
jcsirot
force-pushed
the
inspect_info_running_app_only
branch
from
November 8, 2019 13:34
5c6c2d2
to
8abe274
Compare
Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
jcsirot
force-pushed
the
inspect_info_running_app_only
branch
from
November 8, 2019 14:13
8abe274
to
7670989
Compare
rumpl
approved these changes
Nov 12, 2019
eunomie
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add an
app inspect
command to display info on running applications- How I did it
Create a new command
Display information from Installation Claim for Installation, Application & Parameters section
Call the status CNAB action to display the list of running services
- How to verify it
TBD
- Description for the changelog
Add a new inspect command to display information on running applications
- A picture of a cute animal (not mandatory but encouraged)