This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Allow rm of multiple apps in one command #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zappy-shu
force-pushed
the
APP-308-rm-multi-apps
branch
3 times, most recently
from
9e894bb to
3453532
Compare
Adds ability to remove multiple running apps with a single command. E.g.: docker app rm app1 app2 Attempts to remove all listed apps before returning any errors same as with docker app image rm. Signed-off-by: Nick Adcock <nick.adcock@docker.com>
zappy-shu
force-pushed
the
APP-308-rm-multi-apps
branch
from
3453532 to
4b39e99
Compare
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
==========================================
- Coverage 70.44% 70.41% -0.03%
==========================================
Files 67 67
Lines 3729 3732 +3
==========================================
+ Hits 2627 2628 +1
- Misses 758 759 +1
- Partials 344 345 +1
Continue to review full report at Codecov.
|
Use hashicorp/go-multierror to handle multiple errors when removing multiple apps at once Signed-off-by: Nick Adcock <nick.adcock@docker.com>
zappy-shu
force-pushed
the
APP-308-rm-multi-apps
branch
from
8623fc4 to
518754b
Compare
zappy-shu
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Adds ability to remove multiple running apps with a single command. E.g.:
docker app rm app1 app2Attempts to remove all listed apps before returning any errors same as with docker app image rm.
- How I did it
Changed the
ExactArgstoRequiredMinArgsand loop through the args, appending any errors which are all returned at the end if any exist.- How to verify it
docker app run2 apps with namesapp1andapp2thendocker app rm app1 app2. The output should show each app being removed- Description for the changelog
Allow removing of multiple Apps in one command using space delimited App names. E.g.
docker app rm my-app-1 my-app-2- A picture of a cute animal (not mandatory)