Exclude empty items from input list

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
docker · Sep 5, 2020 · 90d197d · 90d197d
1 parent e01a38b
commit 90d197d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/__tests__/context.test.ts b/__tests__/context.test.ts
@@ -15,13 +15,27 @@ describe('getInputList', () => {
     expect(res).toEqual(['bar', 'baz']);
   });
 
+  it('remove empty lines correctly', async () => {
+    setInput('foo', 'bar\n\nbaz');
+    const res = await context.getInputList('foo');
+    console.log(res);
+    expect(res).toEqual(['bar', 'baz']);
+  });
+
   it('handles comma correctly', async () => {
     setInput('foo', 'bar,baz');
     const res = await context.getInputList('foo');
     console.log(res);
     expect(res).toEqual(['bar', 'baz']);
   });
 
+  it('remove empty result correctly', async () => {
+    setInput('foo', 'bar,baz,');
+    const res = await context.getInputList('foo');
+    console.log(res);
+    expect(res).toEqual(['bar', 'baz']);
+  });
+
   it('handles different new lines correctly', async () => {
     setInput('foo', 'bar\r\nbaz');
     const res = await context.getInputList('foo');

diff --git a/dist/index.js b/dist/index.js
diff --git a/src/context.ts b/src/context.ts
@@ -128,7 +128,11 @@ export async function getInputList(name: string, ignoreComma?: boolean): Promise
   }
   return items
     .split(/\r?\n/)
-    .reduce<string[]>((acc, line) => acc.concat(!ignoreComma ? line.split(',') : line).map(pat => pat.trim()), []);
+    .filter(x => x)
+    .reduce<string[]>(
+      (acc, line) => acc.concat(!ignoreComma ? line.split(',').filter(x => x) : line).map(pat => pat.trim()),
+      []
+    );
 }
 
 export const asyncForEach = async (array, callback) => {