Add action definitions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Signed-off-by: Nick Adcock <nick.adcock@docker.com>
mat007
reviewed
Mar 6, 2020
README.md
Outdated
|
|
||
| ### `target` | ||
|
|
||
| Sets the target build stage to build. |
There was a problem hiding this comment.
nit: maybe Sets the stage to build?
There was a problem hiding this comment.
Copied from the docker help build output. It's not great though I'll admit. Maybe Set the target stage to build?
action.yml
Outdated
| - build-push | ||
| inputs: | ||
| username: | ||
| description: Username used to log in to a docker registry. If not set then no login will occur |
There was a problem hiding this comment.
nit: is this intentional that there is no dot at the end of all the descriptions?
There was a problem hiding this comment.
Just been following the examples in the official docs: https://help.github.com/en/actions/building-actions/metadata-syntax-for-github-actions#description
There doesn't appear to be an actual standard though
Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Closed
3 tasks
3 tasks
3 tasks
ghost
mentioned this pull request
3 tasks
3 tasks
3 tasks
3 tasks
Closed
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the action definition along with the readme, apache 2 license, and basic CI flow to test the action works