Fix and cleanup of v2 setup actions #93
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
v2-fix-setup-actions
branch
from
f376e82 to
e9cb922
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
v2-fix-setup-actions
branch
from
030beb5 to
6aa6546
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
v2-fix-setup-actions
branch
from
20b7c93 to
82c243c
Compare
| | `version` | String | _the one installed on the runner_ | [Buildx](https://github.com/docker/buildx) version. e.g. `v0.3.0`, `latest` | | ||
| | `driver` | String | `docker-container` | Sets the [builder driver](https://github.com/docker/buildx#--driver-driver) to be used. | | ||
| | `driver-opt` | String | | Passes additional [driver-specific options](https://github.com/docker/buildx#--driver-opt-options). e.g. `image=moby/buildkit:master` | | ||
| | `buildkitd-flags` | String | | [Flags for buildkitd](https://github.com/moby/buildkit/blob/master/docs/buildkitd.toml.md) daemon. | |
There was a problem hiding this comment.
wondering if should add special case for allow-insecure-entitlement so it works together with allow in build action. Or actually, maybe we should just always enable allow-insecure-entitlement in github actions context as these run in a isolated VM anyway. I could also add --allow-insecure-entitlement=all in buildkit.
There was a problem hiding this comment.
wondering if should add special case for allow-insecure-entitlement so it works together with allow in build action. Or actually, maybe we should just always enable allow-insecure-entitlement in github actions context as these run in a isolated VM anyway.
Yes, that was the purpose of integrating buildkit-flags so that I can use a local registry for testing. And indeed in the case of GitHub Actions it seems logical to me to enable allow-insecure-entitlement by default.
I could also add --allow-insecure-entitlement=all in buildkit.
Yes SGTM!
There was a problem hiding this comment.
@tonistiigi Ok local registry is working in our ci workflow.
Ref. #71
buildkitd-flagsinput