Skip to content

DAP: Step in will pause at points that do not have an associated source line #3565

@jsternberg

Description

@jsternberg

Contributing guidelines

I've found a bug and checked that ...

  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

The DAP adapter is intended to only stop on valid source lines. It's currently also stopping on internal lines that are part of the LLB but not part of the source file. The most prominent example is the build context. When a copy occurs from the build context, step in will treat the build context as its own stage and include it as part of the stack trace. This position doesn't exist and the DAP client will get confused about where in the file it's supposed to be. We used to skip past these points, but it seems like one of the refactors to the stepping functionality broke this so "step in" will now step into build contexts.

Expected behaviour

It's supposed to ignore those LLB instructions and step in when copying from a build context should act the same as step next.

Actual behaviour

It acts as if the build context is a build stage it is copying from and it "enters" the stage.

Buildx version

Found on master at revision 22e7bf6

Configuration

See #3566 for an integration test that exposes this bug.

Additional info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/dapkind/bugSomething isn't workingpriority/p3Best effort, those are nice to have / minor issues

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions