vendor: github.com/docker/cli v24.0.4 #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: docker/cli@v24.0.2...v24.0.4 notable changes: - ssh: fix error on commandconn close, add ping and default - commandconn: return original error while closing Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Oups commented on the wrong PR, see #1960 (review) |
This hook was added in 278f94a and 72758fe to suppress spurious warnings printed by the CLI's cli/connhelper/commandconn package; https://github.com/docker/cli/blob/3fb4fb83dfb5db0c0753a8316f21aea54dab32c5/cli/connhelper/commandconn/commandconn.go#L203-L214 Those logs were removed in docker/cli@a5ebe22 so we can remove the hook. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jul 19, 2023
Comment on lines
-55
to
-65
| // filter out useless commandConn.CloseWrite warning message that can occur | ||
| // when listing builder instances with "buildx ls" for those that are | ||
| // unreachable: "commandConn.CloseWrite: commandconn: failed to wait: signal: killed" | ||
| // https://github.com/docker/cli/blob/3fb4fb83dfb5db0c0753a8316f21aea54dab32c5/cli/connhelper/commandconn/commandconn.go#L203-L214 | ||
| logrus.AddHook(logutil.NewFilter([]logrus.Level{ | ||
| logrus.WarnLevel, | ||
| }, | ||
| "commandConn.CloseWrite:", | ||
| "commandConn.CloseRead:", | ||
| )) | ||
|
|
There was a problem hiding this comment.
Removed the hook; #1960 (review)
crazy-max
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: docker/cli@v24.0.2...v24.0.4
notable changes: