Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix non-deterministic compose context path #2014

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

crazy-max
Copy link
Member

related to #1971

Since #1971 the context path is now absolute and although the tests run fine in our containerized environment, it wouldn't work running the tests locally, such as:

=== CONT  TestReadTargetsCompose
    bake_test.go:306: 
        	Error Trace:	X:/dev/neard/www/github/docker_org/buildx/bake/bake_test.go:306
        	Error:      	Not equal: 
        	            	expected: "/src/bake"
        	            	actual  : "/home/foo/buildx/bake"

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit 296832c into docker:master Aug 23, 2023
@crazy-max crazy-max deleted the fix-compose-test branch August 23, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants