Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to LocalMounts implementation #2254

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 10, 2024

build/build.go Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the rm-local-dirs branch 2 times, most recently from 0a58879 to 97e626e Compare February 13, 2024 10:20
@crazy-max crazy-max marked this pull request as ready for review February 13, 2024 10:26
@crazy-max crazy-max force-pushed the rm-local-dirs branch 6 times, most recently from 5ab6dbf to 767ebf9 Compare February 23, 2024 22:22
build/opt.go Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the rm-local-dirs branch 3 times, most recently from 996b82d to 35ba4d6 Compare February 26, 2024 09:03
@crazy-max crazy-max added this to the v0.13.0 milestone Feb 27, 2024
@tonistiigi tonistiigi removed this from the v0.13.0 milestone Feb 28, 2024
@tonistiigi
Copy link
Member

I removed this from the milestone as I don't think it has a user-visible impact. Lets get this in right after the release.

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want you can separate out the first commit. Makes reviewing easier.

build/opt.go Outdated Show resolved Hide resolved
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit 2565c74 into docker:master Mar 14, 2024
63 checks passed
@crazy-max crazy-max deleted the rm-local-dirs branch March 14, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants