-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: handle multiple docker versions #2307
Conversation
ba4ec65
to
5a62074
Compare
5a62074
to
cf4bc57
Compare
b36edca
to
b0f8fcc
Compare
@tonistiigi As discussed we could also handle builders through |
These seem relevant to this pr: Lines 442 to 443 in 4327ee7
Lines 576 to 577 in 4327ee7
Lines 643 to 644 in 4327ee7
|
WDYM? This PR is about testing multiple dockerd versions. For BuildKit see #2322 |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
b0f8fcc
to
a69d857
Compare
@@ -5,6 +5,7 @@ ARG XX_VERSION=1.5.0 | |||
|
|||
# for testing | |||
ARG DOCKER_VERSION=27.4.0-rc.2 | |||
ARG DOCKER_VERSION_ALT_26=26.1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
26.1.3 is the current version shipped on GitHub runners. I think it makes sense to test this alt version.
needs testutil: add binary and extraEnv opt for dockerd worker moby/buildkit#4736