Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: remove gogoproto #2713

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Commits on Oct 2, 2024

  1. protobuf: remove gogoproto

    Removes gogo/protobuf from buildx and updates to a version of
    moby/buildkit where gogo is removed.
    
    This also changes how the proto files are generated. This is because
    newer versions of protobuf are more strict about name conflicts. If two
    files have the same name (even if they are relative paths) and are used
    in different protoc commands, they'll conflict in the registry.
    
    Since protobuf file generation doesn't work very well with
    `paths=source_relative`, this removes the `go:generate` expression and
    just relies on the dockerfile to perform the generation.
    
    Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
    jsternberg committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b35a0f4 View commit details
    Browse the repository at this point in the history