build: add OTEL span around build function #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
reviewed
Oct 17, 2024
build/build.go
Outdated
| @@ -500,7 +500,9 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opts map[ | |||
| resultHandle, rr, err = NewResultHandle(ctx, cc, *so, "buildx", buildFunc, ch) | |||
| resultHandleFunc(dp.driverIndex, resultHandle) | |||
| } else { | |||
| span, ctx := tracing.StartSpan(ctx, "Build") | |||
There was a problem hiding this comment.
Does casing matters?
Suggested change
| span, ctx := tracing.StartSpan(ctx, "Build") | |
| span, ctx := tracing.StartSpan(ctx, "build") |
There was a problem hiding this comment.
🤷 Is there a convention? Or should we define one?
There was a problem hiding this comment.
Don't think there is any convention but it's lowercasing from what I see on buildkit repo: https://github.com/search?q=repo%3Amoby%2Fbuildkit%20tracing.StartSpan&type=code
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
otel-build
branch
from
245e025
to
f35dae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement for OTEL trace to group all the grpc requests made by build function under the same parent.