Add ability to output json lists in metadata build file #2777
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
tonistiigi
reviewed
Nov 4, 2024
| var dt []byte | ||
| j, ok := v.(string) | ||
| if ok { | ||
| d, err := base64.StdEncoding.DecodeString(string(j)) |
There was a problem hiding this comment.
There is already a decoder in decodeExporterResponse in the same code path, so it shouldn't be duplicated.
| out := make(map[string]interface{}) | ||
| for k, v := range response { | ||
| var dt []byte | ||
| j, ok := v.(string) |
There was a problem hiding this comment.
If this means that any base64 string is decoded then I don't think that can be done as false positives can happen when regular string happens to be valid base64. Valid JSON array could work though, assuming that previous versions of buildx does not produce an error (previous versions failing to decode is unavoidable I guess).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports metadata descriptors list in BuildKit moby/buildkit#5454