bake: implement composable attributes for attestations #2848
+316
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #2814. |
jsternberg
force-pushed
the
bake-composable-attributes-attests
branch
from
1c6b5ef to
86061dd
Compare
tonistiigi
reviewed
Dec 17, 2024
| @@ -10,6 +12,167 @@ import ( | |||
| "github.com/tonistiigi/go-csvvalue" | |||
| ) | |||
|
|
|||
| type Attests []*Attest | |||
There was a problem hiding this comment.
These types with ToPB/String/(Un)Marshal*/FromToCty are good candidates for unit tests. Some part of the helpers can probably be shared. I'm worried about cases where somebody makes a change in one of these functions but forgets to make a matching change in another.
jsternberg
force-pushed
the
bake-composable-attributes-attests
branch
from
86061dd to
14ce964
Compare
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
bake-composable-attributes-attests
branch
from
14ce964 to
4f81bcb
Compare
|
We can leave the unit tests for follow-up as it contains fields not in this PR. |
tonistiigi
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.