Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bake: test empty override #2871

Merged
merged 1 commit into from
Dec 18, 2024
Merged

bake: test empty override #2871

merged 1 commit into from
Dec 18, 2024

Conversation

jsternberg
Copy link
Collaborator

Cherry pick of afc9ceb.

tonistiigi
tonistiigi reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not testing the return value of ReadTargets like the old one did (same can be added to override case).

@jsternberg @crazy-max
bake: test empty override
1e992b2 
Co-authored-by: CrazyMax <github@crazymax.dev>
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
@jsternberg jsternberg force-pushed the bake-empty-variable-tests branch from 300b21a to 1e992b2 Compare December 18, 2024 17:56
@jsternberg
Copy link
Collaborator Author

@tonistiigi done and I also added a check to make sure that app was actually in the list of targets. This is because the length of m["foo"].Outputs would also be zero so we want to verify "app" is actually there.

@tonistiigi tonistiigi merged commit 0dfc4a1 into docker:master Dec 18, 2024
122 checks passed
@jsternberg jsternberg deleted the bake-empty-variable-tests branch December 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
area/bake area/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsternberg @tonistiigi