dap: skip the set breakpoints test because of possible deadlock #3568
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit test can potentially deadlock in some way that the go runtime doesn't detect it and it runs for 30 minutes. Skipping the test until we either fix it or replace it with an equivalent integration test. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
rcjsuen
approved these changes
Dec 12, 2025
Contributor
rcjsuen
left a comment
rcjsuen
left a comment
There was a problem hiding this comment.
Sorry about this, folks. :(
Contributor
|
Do we have an issue created to remind ourselves to review this? |
Collaborator
Author
|
Not at the moment but I'll probably end up covering it in the integration tests. |
Collaborator
Author
|
I found the potential race issue while working on the integration tests which is fixed in this PR: #3566 When the test client makes a request, it registers the request sequence id with a map on the client so it can associate the response to the correct channel. It was adding this sequence id to the map after it sent the message rather than before so receiving the message very quickly could cause the response to be dropped and then code that was polling for the response would hang even though the response had been received. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test can potentially deadlock in some way that the go runtime
doesn't detect it and it runs for 30 minutes. Skipping the test until we
either fix it or replace it with an equivalent integration test.