-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Kubernetes commands from experimental #1068
Remove Kubernetes commands from experimental #1068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
Let's wait for the required PR to get merge before merging this one though 👼
271acef
to
72fdc36
Compare
Rebased |
expectedOrchestrator: "swarm", | ||
expectedKubernetes: false, | ||
expectedSwarm: true, | ||
}, | ||
{ | ||
doc: "kubernetesConfigFile", | ||
configfile: `{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a couple more "experimental": "enabled"
below; think those can be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
72fdc36
to
f2b75a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
I removed the experimentalCli annotations and all the experimental code linked to the Kubernetes features.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)