Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check errors when initializing the docker client in the help command #1119

Conversation

silvin-lubecki
Copy link
Contributor

- How to verify it

# No segfault
$ docker --help --tlsverify 
could not read CA certificate "/Users/user/.docker/ca.pem": open /Users/user/.docker/ca.pem: no such file or directory

- Description for the changelog
Fix #1113 "Segfault on --help with --tlsverify if no ca certificate is present"

- A picture of a cute animal (not mandatory but encouraged)
image

…cate is present"

Errors were not checked while initializing the docker client in the help command

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@vdemeester
Copy link
Collaborator

cc @thaJeztah we may want to backport this fix in docker-ce and docker-ee 👼

@vdemeester vdemeester merged commit aac3124 into docker:master Jun 8, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.06.0 milestone Jun 8, 2018
@silvin-lubecki silvin-lubecki deleted the fix-help-docker-client-initialization branch June 8, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants