Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.06] backport bash completion enhancements #1173

Merged
merged 2 commits into from
Jul 2, 2018
Merged

[18.06] backport bash completion enhancements #1173

merged 2 commits into from
Jul 2, 2018

Conversation

thaJeztah
Copy link
Member

Backport of;

/cc @vdemeester @albers

albers added 2 commits July 2, 2018 15:12
@albers @thaJeztah
Add bash completion for dockerd --default-address-pool
547b9a4 
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 0e6d9df)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Add bash completion for exec_die event
74b30e7 
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 8443982)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from albers as a code owner July 2, 2018 13:13
@thaJeztah thaJeztah added this to the 18.06.0 milestone Jul 2, 2018
silvin-lubecki
silvin-lubecki approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Jul 2, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

albers
albers approved these changes Jul 2, 2018
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@albers albers merged commit c6c52ae into docker:18.06 Jul 2, 2018
@thaJeztah thaJeztah deleted the 18.06-backport-bash-completion branch July 2, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

@albers albers albers approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/completion status/2-code-review
Projects
None yet
Milestone
18.06.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thaJeztah @vdemeester @albers @silvin-lubecki @GordonTheTurtle