Migrate to non-deprecated functions of api/types/filters
#1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `Contains` instead of `Include` - Use `ToJSON` instead of `ToParam` - Remove usage of `ParseFlag` as it is deprecated too Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
use-non-deprecated-filters-funcs
branch
from
88cdacf to
55edeb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
==========================================
- Coverage 54.25% 54.23% -0.02%
==========================================
Files 268 268
Lines 17799 17805 +6
==========================================
Hits 9656 9656
- Misses 7536 7542 +6
Partials 607 607 |
|
Needs 42.86% more coverage |
selansen
pushed a commit
to selansen/cli
that referenced
this pull request
Jul 29, 2018
…ters-funcs Migrate to non-deprecated functions of `api/types/filters`
selansen
pushed a commit
to selansen/cli
that referenced
this pull request
Jul 29, 2018
…ters-funcs Migrate to non-deprecated functions of `api/types/filters` Signed-off-by: selansen <elango.siva@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containsinstead ofIncludeToJSONinstead ofToParamParseFlagas it is deprecated tooSee https://godoc.org/github.com/docker/docker/api/types/filters for
Deprecatedmethods.Signed-off-by: Vincent Demeester vincent@sbr.pm