Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] Expose product license in info output #1313

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

dhiltgen
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #1313 into 18.09 will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##            18.09    #1313      +/-   ##
==========================================
- Coverage   54.78%   54.78%   -0.01%     
==========================================
  Files         293      293              
  Lines       19322    19324       +2     
==========================================
  Hits        10586    10586              
- Misses       8073     8074       +1     
- Partials      663      664       +1

@andrewhsu andrewhsu changed the title Expose product license in info output [18.09] Expose product license in info output Aug 28, 2018
Copy link
Contributor

@mavenugo mavenugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -204,6 +204,7 @@ func prettyPrintInfo(dockerCli command.Cli, info types.Info) error {
}

fmt.Fprintln(dockerCli.Out(), "Live Restore Enabled:", info.LiveRestoreEnabled)
fmt.Fprintln(dockerCli.Out(), "Product License:", info.ProductLicense)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if info.ProductLicense != "" {

Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
@selansen
Copy link
Contributor

LGTM

@andrewhsu andrewhsu merged commit 8789e93 into docker:18.09 Aug 29, 2018
@thaJeztah thaJeztah added this to the 18.09.0 milestone Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants