[18.09] backport LCOW: --platform on import (already in API) #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <jhoward@microsoft.com> (cherry picked from commit b55a0b6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @simonferquel @jhowardmsft @chris-crone PTAL |
thaJeztah
added
kind/experimental
status/2-code-review
and removed
status/0-triage
labels
Codecov Report
@@ Coverage Diff @@
## 18.09 #1375 +/- ##
==========================================
+ Coverage 54.55% 54.56% +<.01%
==========================================
Files 294 294
Lines 19401 19403 +2
==========================================
+ Hits 10585 10587 +2
Misses 8152 8152
Partials 664 664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although LCOW is still experimental, this patch was fairly trivial, so I think it'd be ok to backport (but open to input)
This backports #1371 to the 18.09 branch
cherry-pick was clean; no conflicts