Using strings.Builder instead of string appending #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li Yi <denverdino@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1423 +/- ##
==========================================
+ Coverage 54.26% 54.27% +0.01%
==========================================
Files 289 289
Lines 19331 19337 +6
==========================================
+ Hits 10490 10496 +6
Misses 8165 8165
Partials 676 676 |
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix #1422
Using strings.Builder instead of string appending in image prune command
- How I did it
- How to verify it
Pass the test case and the manual test
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)