Fix warnings not being printed on "create", only on "run" #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Dec 13, 2018
| @@ -165,6 +166,9 @@ func createContainer(ctx context.Context, dockerCli command.Cli, containerConfig | |||
| networkingConfig := containerConfig.NetworkingConfig | |||
| stderr := dockerCli.Err() | |||
|
|
|||
| warnOnOomKillDisable(*hostConfig, stderr) | |||
| warnOnLocalhostDNS(*hostConfig, stderr) | |||
There was a problem hiding this comment.
FWIW, I actually want to move these warnings to the daemon (similar as to what I did in #1225 / moby/moby#37502, that way the daemon can decide if the container configuration has possible issues, and we can provide warnings for situations where (e.g.) memory-limit is not supported by the daemon, so will be ignored
vdemeester
approved these changes
Dec 13, 2018
|
Ah, boo! I disabled the automatic gofmt, because it keeps messing up my files when switching between repos haha |
Previously, these errors were only printed when using `docker run`, but were omitted when using `docker container create` and `docker container start` separately. Given that these warnings apply to both situations, this patch moves generation of these warnings to `docker container create` (which is also called by `docker run`) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
warn_on_create
branch
from
03eca4c
to
7c514a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
==========================================
+ Coverage 55.26% 55.29% +0.03%
==========================================
Files 289 289
Lines 19385 19381 -4
==========================================
+ Hits 10713 10717 +4
+ Misses 7977 7970 -7
+ Partials 695 694 -1 |
dnephin
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these errors were only printed when using
docker run, but were omitted when usingdocker container createanddocker container startseparately.Given that these warnings apply to both situations, this patch moves generation of these warnings to
docker container create(which is also called bydocker run)- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)