Add support for pull-policies in Kubernetes stacks (v1alpha3) #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
- Coverage 55.89% 55.66% -0.23%
==========================================
Files 299 302 +3
Lines 20479 20574 +95
==========================================
+ Hits 11446 11452 +6
- Misses 8210 8296 +86
- Partials 823 826 +3 |
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
simonferquel
force-pushed
the
pull-secret
branch
from
87d7598
to
ad5c1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1617
- What I did
Compose on Kubernetes now supports explicitly specifying a pull policy on a service. This PR enables support for that with the
x-pull-policyfield on service configurations.- How I did it
Following the pattern introduced with pull secrets, I added a declaration of the
hasPullPolicycapability, and pass whatever is contained in thex-pull-policyextra field.- How to verify it
This is covered by a unit test
- Description for the changelog
Services in a Kubernetes stack can now specify their PullPolicy using the extra field
x-pull-policy.