Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/38518 Add builder info #1660

Closed
wants to merge 3 commits into from

Conversation

kwojcicki
Copy link

@kwojcicki kwojcicki commented Feb 6, 2019

PR Re-opened from #1659

Signed-off-by: Krystian Wojcicki kwojcicki@sympatico.ca

Client part of moby/moby#38518

- What I did
Added the builder version in the docker info command

- How I did it
reading the response from the server and printing out the corresponding version
also updated the version of moby/moby being used to get the new struct information.

- How to verify it
typing docker info/the tests

- Description for the changelog
Docker info prints the default builder

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Krystian Wojcicki <kwojcicki@sympatico.ca>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "feature/38518_builder_info" git@github.com:kwojcicki/cli.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354510800
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

# The first commit's message is:

squashed

Signed-off-by: Krystian Wojcicki <kwojcicki@sympatico.ca>

updated golden files

# The 2nd commit message will be skipped:

#	updated golden files
Signed-off-by: Krystian Wojcicki <kwojcicki@sympatico.ca>
@thaJeztah
Copy link
Member

Looks like this needs a rebase now, because another PR brought in the "moby" bump.

There's still some debate about the API changes; if we want to include just the version or if we need to include more information about the builder in future (in which case, we may want to change the API response to use a "struct" for builder).

I was also thinking what this info would be used for; including (e.g.) BuildKit as a component in the /version output? (similar to moby/moby#37974)

@kwojcicki
Copy link
Author

@thaJeztah would you happen to know the correct way to update the golden files? I had to hack at the makefile to set the flag correctly? And also will try rebasing.

@silvin-lubecki silvin-lubecki changed the title Feature/38518 builder info Feature/38518 Add builder info Feb 7, 2019
@thaJeztah
Copy link
Member

hm, good one, I think I ran it manually last time 🤔

but, might want to join the discussion on moby/moby#38688

@thaJeztah
Copy link
Member

closing per the discussion in moby/moby#38688 (comment)

but thanks so much!

@thaJeztah thaJeztah closed this Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants