bash completion: add node type filter #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trapier Marshall <trapier.marshall@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #1860 +/- ##
=======================================
Coverage 56.77% 56.77%
=======================================
Files 309 309
Lines 21668 21668
=======================================
Hits 12301 12301
Misses 8468 8468
Partials 899 899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Make
docker events -f type=<tab><tab>in bash emitnodeas one of the completions.- How I did it
Added
nodeto the completion entry fortype.- How to verify it
Copy the modified completion file to
/usr/share/bash-completion/completions/dockeron a centos 7 manager node, then log out and log back in, then tested tab completion. Join a node to the swarm with the event filter running, and observe events.- Description for the changelog
Add bash tab completion for node event type filter.
- A picture of a cute animal (not mandatory but encouraged)