Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang 1.12.5 #1864

Merged
merged 1 commit into from
May 11, 2019
Merged

Conversation

tao12345666333
Copy link
Contributor

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

- What I did

go1.12.5 (released 2019/05/06) includes fixes to the compiler, the linker,
the go command, the runtime, and the os package. See the
Go 1.12.5 milestone on our issue tracker for details.

golang/go@go1.12.4...go1.12.5

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Contributor Author

The cross build job need wait docker/golang-cross#29 been merged.

@thaJeztah
Copy link
Member

docker/golang-cross#29 was merged and tagged, so waiting for the builds to complete there 👍

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1864 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1864   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files         309      309           
  Lines       21668    21668           
=======================================
  Hits        12301    12301           
  Misses       8468     8468           
  Partials      899      899

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1864 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1864   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files         309      309           
  Lines       21668    21668           
=======================================
  Hits        12301    12301           
  Misses       8468     8468           
  Partials      899      899

@tiborvass tiborvass merged commit 53fc257 into docker:master May 11, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone May 11, 2019
@tao12345666333 tao12345666333 deleted the bump-golang-1.12.5 branch May 11, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants