Dockerfile: use GO_VERSION build-arg for overriding Go version #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows overriding the version of Go without making modifications in the
source code, which can be useful to test against multiple versions.
For example:
make GO_VERSION=1.13beta1 -f docker.Makefile binary
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @silvin-lubecki @vdemeester ptal /cc @seemethere |
Codecov Report
@@ Coverage Diff @@
## master #2008 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 311 311
Lines 21836 21836
=======================================
Hits 12402 12402
Misses 8519 8519
Partials 915 915 |
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
What about removing the default args and force to set it, and define it only one time in the Makefile? You would then have only one place to update the go version?
Member
Author
|
@silvin-lubecki it's good to have a default in the Dockerfile; Dockerfiles should be "buildable" without having to pass specific build-args |
Member
Author
|
That default could be |
This was referenced Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows overriding the version of Go without making modifications in the
source code, which can be useful to test against multiple versions.
For example: