[18.09 backport] Disable TLS for e2e docker-in-docker daemon #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @kolyshkin @silvin-lubecki ptal |
The edge channel is deprecated and no longer updated Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 08fd6dd) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The docker-in-docker image now enables TLS by default (added in docker-library/docker#166), which complicates testing in our environment, and isn't needed for the tests we're running. This patch sets the `DOCKER_TLS_CERTDIR` to an empty value to disable TLS. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit b1a3c1a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
18.09_backport_fix_e2e
branch
from
8985b56 to
9c8ac0a
Compare
Member
Author
|
updated; added #1992 |
Codecov Report
@@ Coverage Diff @@
## 18.09 #2021 +/- ##
=======================================
Coverage 54.29% 54.29%
=======================================
Files 291 291
Lines 19459 19459
=======================================
Hits 10565 10565
Misses 8214 8214
Partials 680 680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1992 and #2020
The docker-in-docker image now enables TLS by default (added in
docker-library/docker#166), which complicates testing in our
environment, and isn't needed for the tests we're running.
This patch sets the
DOCKER_TLS_CERTDIRto an empty value todisable TLS.