Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service_create.md #2054

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

jescobar-docker
Copy link
Contributor

Typo in word 'propagation'.

- What I did
Correct a typo
- How I did it
N/A
- How to verify it
N/A
- Description for the changelog

It was just a typo being corrected.

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:jescobar-docker/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov-io
Copy link

Codecov Report

Merging #2054 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2054   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files         311      311           
  Lines       21836    21836           
=======================================
  Hits        12400    12400           
  Misses       8520     8520           
  Partials      916      916

Typo in word propagation.

Signed-off-by: Jose Escobar <joseescobar@JE-MBP15-2017.local>
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants