-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump docker/docker to a09e6e323e55e1a9b21df9c2c555f5668df3ac9b #2158
Conversation
ef508c4
to
e6e167a
Compare
ef65ee8
to
a596de8
Compare
full diff: microsoft/hcsshim@672e52e...2226e08 - microsoft/hcsshim#569 Enhancement: add osversion.Build() utility - relates to moby/moby#39100 Use Microsoft/hcsshim constants and deprecate pkg/system.GetOsVersion() Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
a596de8
to
5dc2f59
Compare
full diff: moby/moby@b6684a4...a09e6e3 relevant changes: - moby/moby#39995 Update containerd binary to v1.2.10 - moby/moby#40001 Update runc to v1.0.0-rc8-92-g84373aaa (CVE-2019-16884) - moby/moby#39999 bump golang 1.13.1 (CVE-2019-16276) - moby/moby#40102 bump golang 1.13.3 (CVE-2019-17596) - moby/moby#40134 Revert "homedir: add cgo or osusergo buildtag constraints for unix" - reverts moby/moby#39994 homedir: add cgo or osusergo buildtag constraints for unix, in favor of documenting when to set the `osusergo` build tag. The `osusergo` build-flag must be used when compiling a static binary with `cgo` enabled, and linking against `glibc`. - moby/moby#39983 builder: remove legacy build's session handling This feature was used by docker build --stream and it was kept experimental. Users of this endpoint should enable BuildKit anyway by setting Version to BuilderBuildKit. - Related: docker#2105 build: remove --stream (was experimental) - moby/moby #40045 Bump logrus 1.4.2, go-shellwords, mergo, flock, creack/pty, golang/gddo, gorilla/mux - moby/moby#39713 bump containerd and dependencies to v1.3.0 - moby/moby#39987 Add ability to handle index acknowledgment with splunk log driver - moby/moby#40070 Use ocischema package instead of custom handler - relates to moby/moby#39727 Docker 19.03 doesn't support OCI image - relates to docker/hub-feedback#1871 - relates to distribution/distribution#3024 - moby/moby#39231 Add support for sending down service Running and Desired task counts - moby/moby#39822 daemon: Use short libnetwork ID in exec-root - moby/moby#39100 Use Microsoft/hcsshim constants and deprecate pkg/system.GetOsVersion() - updates/requires Microsoft/hscshim@2226e083fc390003ae5aa8325c3c92789afa0e7a Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
5dc2f59
to
7f6cd64
Compare
whoop! with moby/moby#40134 merged, and included in this, I could revert all local changes, so this is now only a vendor bump, and ready for review ping @silvin-lubecki @vdemeester @kolyshkin PTAL 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
depends on:
build static binaries with -tags osusergo #2162 build static binaries with -tags osusergobump Microsoft/hcsshim 2226e083fc390003ae5aa8325c3c92789afa0e7a
full diff: microsoft/hcsshim@672e52e...2226e08
bump docker/docker to a09e6e323e55e1a9b21df9c2c555f5668df3ac9b
full diff: moby/moby@b6684a4...a09e6e3
relevant changes:
in favor of documenting when to set the
osusergo
build tag. Theosusergo
build-flag must be used when compiling a static binary with
cgo
enabled,and linking against
glibc
.This feature was used by docker build --stream and it was kept experimental.
Users of this endpoint should enable BuildKit anyway by setting Version to BuilderBuildKit.
golang/gddo, gorilla/mux
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)