Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change example networks #2231

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Change example networks #2231

merged 1 commit into from
Jan 6, 2020

Conversation

oscrx
Copy link
Contributor

@oscrx oscrx commented Dec 23, 2019

- What I did
Change the example networks to allowed private ranges (192.168.0.0/16) according to RFC1918.
- How I did it
With the editor.
- How to verify it
Check the diff.
- Description for the changelog
Change the network example to something allowed.

- A picture of a cute animal (not mandatory but encouraged)
Cute doggo

@oscrx oscrx requested a review from thaJeztah as a code owner December 23, 2019 19:20
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:oscrx/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes itself look good, but could you sign-off your commit, otherwise CI won't pass and we won't be able to accept the PR (our bot provided some instructions above); also see https://github.com/docker/cli/blob/master/CONTRIBUTING.md#sign-your-work

Signed-off-by: Oscar Wieman <oscar@oscarr.nl>
@oscrx
Copy link
Contributor Author

oscrx commented Jan 6, 2020

Excuse me, I must not have payed enough attention. It should be fine now.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks!

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants