Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03 backport] Bump grpc to v1.23.1 #2373

Merged
merged 2 commits into from
Mar 3, 2020
Merged

[19.03 backport] Bump grpc to v1.23.1 #2373

merged 2 commits into from
Mar 3, 2020

Conversation

tiborvass
Copy link
Collaborator

@tiborvass tiborvass commented Mar 3, 2020 •
edited
Loading

Tibor Vass and others added 2 commits March 3, 2020 21:39
vendor: update grpc to v1.23.0
a51e9e6 
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 70a4eb2)
Signed-off-by: Tibor Vass <tibor@docker.com>
@thaJeztah
vendor: bump google.golang.org/grpc v1.23.1
0e40b91 
full diff: grpc/grpc-go@v1.23.0...v1.23.1

- grpc/grpc-go#3018 server: set and advertise max frame size of 16KB
- grpc/grpc-go#3017 grpclb: fix deadlock in grpclb connection cache
    - Before the fix, if the timer to remove a SubConn fires at the
      same time NewSubConn cancels the timer, it caused a mutex leak
      and deadlock.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 013151f)
Signed-off-by: Tibor Vass <tibor@docker.com>
thaJeztah
thaJeztah approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green

@thaJeztah thaJeztah added this to the 19.03.7 milestone Mar 3, 2020
@thaJeztah thaJeztah changed the title [19.03] Bump grpc to v1.23.1 [19.03 backport] Bump grpc to v1.23.1 Mar 3, 2020
@thaJeztah thaJeztah merged commit eb310fc into docker:19.03 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
19.03.7
Development

Successfully merging this pull request may close these issues.
2 participants
@tiborvass @thaJeztah