Jenkinsfile: split e2e tests to separate stages #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-experimental, experimental, and ssh-connhelper stages are running the same tests, which makes it difficult to find _which_ variant of the test failed if they all run in the same stage. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
jenkins_split
branch
from
a061e17 to
ff2c1c0
Compare
|
I'd rather avoid jenkinsifying too much. Can't we add it to the test name instead? |
|
They're the same tests, only with different environment variables set; see it as similar to running tests with |
tiborvass
approved these changes
Apr 11, 2020
|
looks like this was rolled up into #2538 for 19.03, so removing the "cherry-pick" label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-experimental, experimental, and ssh-connhelper stages are running the same tests, which makes it difficult to find which variant of the test failed if they all run in the same stage.
With this change: